search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
65 stars 103 forks source link

Limit pitchfork command to developers #358

Closed jayvdb closed 6 years ago

jayvdb commented 6 years ago

https://github.com/coala/corobo/issues/36 requested "When issued by an authorized person to cobot,.." , however that bit wasnt done. This needs to be fixed before GCI or there will be mayhem when this easter egg is found.

aashraybhandar1 commented 6 years ago

@jayvdb How do I check if the person issuing the command is a developer? Do I have to use labhub to do the same?

aashraybhandar1 commented 6 years ago

Also should pitchfork be part of labhub ?? @jayvdb

jayvdb commented 6 years ago

Yes, the data you need is in labhub, so the pitchfork plugin needs to depend on labhub, and get the data from there. pitchfork should not be part of labhub

Vamshi99 commented 6 years ago

ping @aashraybhandar1 Are you working on this? If not, let us know.

aashraybhandar1 commented 6 years ago

Hey I'm really sorry.I had my end semester exams so wasn't able to continue working on it. I do want to work on this issue and I will try to wrap it up in the and atleast send the first pull request in the next couple of days.

jayvdb commented 6 years ago

Turns out this is hard due to the problem of testing dependent plugins

jayvdb commented 6 years ago

This needs to be implemented as a filter to prevent access to any command based on configuration.