coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

Use activate instead of __init__ for LabHub plugins #554

Closed nvzard closed 6 years ago

jayvdb commented 6 years ago

We have many issues which are effectively about this, allowing the plugin to start without automatically logging into with the tokens and fetching everything.

See https://github.com/coala/corobo/issues/357 and https://github.com/coala/corobo/issues/253 and others in labhub label.

All of those require removing the __init__ and using the correct plugin startup sequence. IMO this issue will be automatically fixed during one of those. Just fixing __init__ -> activate is ignoring the elephant in the room, and is code churn.