coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

Moban #568

Closed jayvdb closed 6 years ago

jayvdb commented 6 years ago

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @jayvdb, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

shikharvaish28 commented 6 years ago

@jayvdb https://github.com/coala/corobo/pull/568/commits/c37af69bea7ad79a5dc7014b060a8f5bf6e19181 looks good to me.

Just out of curiosity, what was intended in https://github.com/coala/corobo/pull/568/commits/d3e355f6a80b62644f187ae752f5ba8ef1cc90fa. The issue you mentioned in https://github.com/coala/corobo/pull/568/commits/d3e355f6a80b62644f187ae752f5ba8ef1cc90fa was closed but what are the other lines for.

jayvdb commented 6 years ago

Hiya @shikharvaish28, thanks for reviewing.

We now have a template for creating the .gitignore, at https://gitlab.com/coala/mobans/blob/master/templates/gitignore.jj2 .

It pulls in a bunch of rules from https://github.com/github/gitignore . The same template is being used on all of our repos, so that they are always in sync, and being updated whenever new rules are added to https://github.com/github/gitignore .

This also means that individual additions in each repo are no longer desirable; instead an addition needs to be proposed at https://github.com/github/gitignore , where they will be reviewed carefully and will benefit more people; when accepted, the change will flow through to our repos.

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @jayvdb, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

nvzard commented 6 years ago

ah failed again due to that bugger

jayvdb commented 6 years ago

ack https://github.com/coala/corobo/pull/568/commits/2d0c920a285263278d2b7f419055ffba59d18604

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: