coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

labhub_test: Increase timeout to fix random CI failures #570

Closed nvzard closed 6 years ago

nvzard commented 6 years ago

Default 5 sec timeout was causing unexpected random CI failure.

Closes https://github.com/coala/corobo/issues/564

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

nvzard commented 6 years ago

Because IGitt is making more that one requests while calling write_repositories method with an invalid token. That is sometimes taking more than 5secs and so the bot message queue is showing a queue.Empty exception as the response is delayed due to IGitt's requests.

I restated the CI 5 times back to back and did not face any breakdown after increasing the timeout limit.

jayvdb commented 6 years ago

fwiw, if this unbreaks the tree, I think it is an acceptable workaround if an issue is raised in IGittso that followup work is done to prevent it biting us again.

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @nvzard, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

nvzard commented 6 years ago

IGitt is doing its work as it is supposed to but it is making a second trial request because the token is invalid. This portion is handled by backoff https://pypi.org/project/backoff/ which makes the request function retry until some condition is met.

jayvdb commented 6 years ago

@nvzard , IGitt is causing this failure. If you cant disable the 'feature' of IGitt causing this failure, then that is a problem in IGitt. And please remove 'fix' from this commit message. It hasnt fixed anything. It has only obscured the problem, and it will bite us again another day. This is a workaround at best. :P A very useful workaround to get the builds working again, but we still need a solution to the problem.

jayvdb commented 6 years ago

50 char limit on commit shortlog.

jayvdb commented 6 years ago

ack https://github.com/coala/corobo/commit/2feedd67eac2af77c47ff44f1c6ff7a3c651615c

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: