coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

Emojis for rage, heart eyes, cake, and penguin have been added. 😡😍🎂🐧 #578

Closed AnirudhaRamesh closed 6 years ago

AnirudhaRamesh commented 6 years ago

Closes https://github.com/coala/corobo/issues/229

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

AnirudhaRamesh commented 6 years ago

Newcomer, 1st issue :) @meetmangukiya

jayvdb commented 6 years ago

Please read and follow https://coala.io/commit carefully.

nvzard commented 6 years ago

@AnirudhaRamesh this change is not really required IMHO. You can get assigned to an issue with label 'difficulty/newcomer' first and then open a PR as a solution for that issue.

jayvdb commented 6 years ago

Abandoned PR.