search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

searchdocs_test: change `http://` links to 'https://` #579

Closed nvzard closed 5 years ago

nvzard commented 6 years ago

Change http to https https://github.com/coala/corobo/blob/de4fbaff1bd227d078f15e8221ea4941fdcf4450/tests/searchdocs_test.py#L7

difficulty/newcomer

ankitb073 commented 6 years ago

Can anyone assign me this issue?

jayvdb commented 6 years ago

Invite sent.

This issue was very badly written.

The cause of the http link is https://github.com/coala/corobo/blob/master/plugins/searchdocs.py , which uses the constant in https://github.com/coala/corobo/blob/master/plugins/constants.py

vaibhav9619 commented 6 years ago

Please assign me this issue

bhavya17037 commented 6 years ago

Hi, can somebody assign me to this issue? This would be my first PR to Coala :)

jayvdb commented 6 years ago

ping @ankitb073 , your PR still need work

jayvdb commented 6 years ago

@vaibhav9619, if you finish your PR first, I will re-assign this issue to you. Be quick.

jayvdb commented 6 years ago

ping @ankitb073 / @vaibhav9619 .

If you dont fix your PRs in the next day or so, they will be discarded and we'll let other newcomers try to solve this.

jayvdb commented 6 years ago

@vaibhav9619 created https://github.com/coala/corobo/pull/614 which is a duplicate of https://github.com/coala/corobo/pull/595 , so they have been removed from @coala .

bkhanale commented 5 years ago

@jayvdb Can I take this up, I'll fix it quickly. Besides there are not so many newcomer issues left :sweat_smile: