Closed Man-Jain closed 6 years ago
@nvzard Sorry, But I am not able to understand why the build is failing on semaphoreci. It would be great if you could help me.
@Man-Jain sorry Internet was down whole day due to govt orders. You need to squash your commits and go through the commit guideline as I said before. Make sure you push your code from a separate branch and not the master branch.
Push again, most probably a restart will fix the semaphore build failure.
Also, you need to rebase.
@nvzard Surprisingly the internet was down in our city also due to Govt. Orders. I have done the other changes but in order to push from a a differnt branch I will have to create a new pull request. So should I close this Pull Request and open a new one?
Don't close the PR. Your master is different from corobo's master, just fix that first and amend your changes. Keep it in mind and don't push from master next time.
@nvzard The semaphoreci Docker is still failing.
@meetmangukiya I can't figure out why semaphore.docker
is failing, can you please take a look.
@Man-Jain as mentioned in the commit guidelines, short log is written in imperative present tense (i.e. Add something, not Adding something or Added something).
Also, use closes
instead of fixes
and read the commit guidelines for the reason.
@nvzard I am very sorry for that mistake. I missed that part. I will surely take care of this next time.
@Man-Jain Semaphore is failing because you pushed your commit from the master branch. Create a new branch and then push your commit. You can go through https://github.com/coala/corobo/blob/861f7f816625554b3de54713d7a56bdc8844aca9/.ci/semaphore.answers.sh#L8 and read the CI logs to find the cause.
@Man-Jain , dont create a new PR. I will try to fix this one for you.
@nvzard Okay, I see I should have carefully made the pull request.
@jayvdb Okay I will make the changes that you have suggested.
please do it really quickly, as all other PRs need to wait for your one to be merged
ack 18a5b33
@gitmate-bot ff
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:
Automated fastforward with GitMate.io was successful! :tada:
Yikes! We missed the 72 char commit body limit with this one :disappointed_relieved:
.coafile : Added PyUnusedCodeBear to [all.python] section
Added the PyUnusedCodeBear to .coafile in [all.python] section and then ran coala command which removes the unused imports from project files.
Fixes :- https://github.com/coala/corobo/issues/531