search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

Minor refractoring in labhub tests #594

Open nvzard opened 6 years ago

nvzard commented 6 years ago

Do minor changes in labhub_tests as asked here https://github.com/coala/corobo/pull/572#pullrequestreview-141693883 (see below)

difficulty/low

ssg2526 commented 6 years ago

i am a beginner, can i help?

nvzard commented 6 years ago

@ssg2526 , have you completed your newcomer issue?

ssg2526 commented 6 years ago

@nvzard, i was not assigned any issues till now. which issue i should work on?

nvzard commented 6 years ago

@ssg2526 you should get yourself assigned to a difficulty/newcomer issue which you understand. I set the difficulty of this issue as low but gitmate-bot missed it maybe :3 I think this issue would be a little tricky for a newcomer, but if you understand this you can get yourself assigned otherwise look for another newcomer issue :)

ssg2526 commented 6 years ago

@nvzard, Thanks for the help.

jayvdb commented 6 years ago

Specifically

self.assertEqual(self.labhub.TEAMS, self.teams)

This should use assertIs instead of assertEqual

in test_invite_cmd

mock_dict['is_room_member'].return_value = True

it is already True, and this should be removed

jayvdb commented 6 years ago

@ssg2526 , you have been sent an invite to join @coala . Please accept it so we can assign this issue to you.

ssg2526 commented 6 years ago

@jayvdb, I have joined the coala

ssg2526 commented 6 years ago

@jayvdb please assign this issue to me

jayvdb commented 6 years ago

Assigned. sorry we tend to respond better on gitter

sudonitin commented 5 years ago

@Makman2 @li-boxuan Please assign me this issue.