search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

Make LabHub is_room_member a private function of the module #602

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

LabHub.is_room_member is unnecessarily a static method of the class.

It can be moved to a private function _is_room_member at the module level, and then the tests can be improved to remove the need to do special plugin mocking.

See https://github.com/coala/corobo/pull/572#discussion_r206302575 for context

srivama commented 6 years ago

Assign this to me.

kumar1202 commented 6 years ago

@jayvdb Can you assign it to me, if no one is working on it.

srivama commented 6 years ago

Ah yes! I was working on this issue earlier, but then it skipped my mind after the exams break. Feel free to work on it once you’re assigned 🙂