coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

plugins/coatils.py: Remove __init__ constructor #604

Closed bhavya17037 closed 6 years ago

bhavya17037 commented 6 years ago

This removes init initializer as the init in this module only invokes super, which happens anyway if _init is removed

Closes https://github.com/coala/corobo/issues/601

Reviewers Checklist

sladyn98 commented 6 years ago

The commit looks good to me.

jayvdb commented 6 years ago

ack https://github.com/coala/corobo/pull/604/commits/b9315d14df029d59142921bc781965467635085a

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada:

jayvdb commented 6 years ago

__new__ & __init__ combined are the implementation of the contructor. You can read about it at https://en.wikipedia.org/wiki/Constructor_(object-oriented_programming) , especially https://en.wikipedia.org/wiki/Constructor_(object-oriented_programming)#Python

Foo() is never a constructor. It is invoking a constructor. It is rarely, and always incorrectly, called the constructor. It should be called instantiation.