Closed bhavya17037 closed 6 years ago
@jayvdb what does "!" In the beginning of "nevermind" mean in the test file?
@bhavya17037 check this out http://errbot.io/en/latest/user_guide/plugin_development/testing.html
That is 'BOT_PREFIX' , just like we use 'corobo' as our bot's prefix. Go through the documentation and you'll understand.
On Mon 6 Aug, 2018, 11:15 AM Bhavya Srivastava, notifications@github.com wrote:
@jayvdb https://github.com/jayvdb what does "!" In the beginning of "nevermind" mean in the test file?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coala/corobo/pull/605#issuecomment-410595303, or mute the thread https://github.com/notifications/unsubscribe-auth/ASansMihYVRaJcVouVKzrF6yhTWiFAxQks5uN9f4gaJpZM4Vvf3r .
Hey @bhavya17037, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Sorry @TravisBuddy, you do not have the necessary permission levels to perform the action.
Hey @bhavya17037, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
@bhavya17037 You have multiple commits, squash all your commits into a single one, refer http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits, don't close this PR. Also, fix errors reported by coala.
don't close this PR
@bhavya17037 Please read what I have said 😄
@Vamshi99 Oh no im so sorry! :( I have made another pull request with the correct and final changes!Could you please review it? :) https://github.com/coala/corobo/pull/606
Add caret in regex pattern so that 'corobo nm' and 'corobo nevermind' are matched only, and only then corobo says "I'm sorry :(". Thus, corobo would not respond with a sorry for commands where nm or nevermind appear anywhere in the command.
Fixes https://github.com/coala/corobo/issues/519
Reviewers Checklist
botcmd
andre_botcmd
decorators.