coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

labhub.py: Alert when @mention is not in room #630

Open abhishalya opened 5 years ago

abhishalya commented 5 years ago

The fix introduces removal of is_room_member function and instead uses callback_message to warn whenever @mention is not in room.

Closes https://github.com/coala/corobo/issues/603

Reviewers Checklist

abhishalya commented 5 years ago

Obviously the tests will fail as I have removed the is_room_member function.

abhishalya commented 5 years ago

@jayvdb Can you please check the warning message so that I can make changes to the tests?

jayvdb commented 5 years ago

tests need to be fixed.

Shouldn't that be a new issue?

No. Fixing/adding unit tests are an integral part of changing code.

abhishalya commented 5 years ago

Blocked until https://github.com/errbotio/err-backend-gitter/issues/38 is solved.