coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

README.md: Update BOT_ADMINS description #631

Closed CLiu13 closed 5 years ago

CLiu13 commented 5 years ago

This adds an explanation that BOT_ADMINS is a space separated list.

Fixes https://github.com/coala/corobo/issues/367

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

Naveenaidu commented 5 years ago

@CLiu13 The changes looks fine to me :) It's great to see that you have no errors in your commit message

Just a point to remember. Please do not ever work on your master branch. Always create a separate branch for each issue. The reason for this is stated here

Everything else looks fine to me.

I'll accept the patch if you could just rebuild the PR. semaphoreci is failing . Just sending in a empty commit would fix the issue.

jayvdb commented 5 years ago

Strange download error. Rebuilding..

CLiu13 commented 5 years ago

@Naveenaidu Thanks for the review! My bad for not creating a separate branch, I will certainly do that on my next task. It seems that the PR is being rebuilt, so I will wait on submitting an empty commit until the rebuild is complete (hopefully it works this time).

jayvdb commented 5 years ago

ack https://github.com/coala/corobo/pull/631/commits/d52f6cfba5c133b1d4e78f4347e864895b4be7c4

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: