coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

config.py: Update default channel list #634

Closed CLiu13 closed 5 years ago

CLiu13 commented 5 years ago

This removes the coala/ prefix from all rooms and adds rooms mentioned in the wiki.

Closes https://github.com/coala/corobo/issues/412

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

CLiu13 commented 5 years ago

Amended the commit and edited the PR message accordingly!

jayvdb commented 5 years ago

Wonderful, now I have noticed we are missing lots more rooms which have been created in the last year.

I added them at https://github.com/coala/coala/wiki/Communication-Channels/_compare/7b0869352fa1bcb6428f396ca69a98903405d120...771b36cd75cfedea4754d6ab619c431c9cef6f12 . Feel free to add them if you have time now. If not, we can merge and someone else can add them.

CLiu13 commented 5 years ago

Sure thing, I will go ahead and add them now.

edit: Completed, I squashed my second commit into the first one to be concise. Let me know if there is anything else you would like me to add!

jayvdb commented 5 years ago

ack https://github.com/coala/corobo/pull/634/commits/ecc22d8fa317dbe3d69b19a65b01758d4c09382e

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: