search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

On Zulip, ROOMS_TO_JOIN should contain valid Zulip rooms #635

Closed jayvdb closed 5 years ago

jayvdb commented 5 years ago

Following on from https://github.com/coala/corobo/pull/634 , the rooms list needs to be updated on backend Zulip to contain only rooms which exist on the coala Zulip server , otherwise there are lots of errors on startup.

Note that 'maintainers' (same as gitter coala/coala/maintainers) and 'gci-mentors-2018' (no gitter equivalent) are two private rooms the bot also needs to join on Zulip.

jayvdb commented 5 years ago

This is GCI task https://codein.withgoogle.com/dashboard/tasks/6377821476749312/

why-does-ie-still-exist commented 5 years ago

@jayvdb does the bot need to scrape zulip, use the zulip api, or is this just a static list of rooms pertinent to the bot?

why-does-ie-still-exist commented 5 years ago

@jayvdb does the bot need to scrape zulip, use the zulip api, or is this just a static list of rooms pertinent to the bot?

Nevermind. I see what you mean(I think) I'll update the list. :-)

jayvdb commented 5 years ago

It can be a static list.