coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

Added 'Zulip' as option for ROOMS_TO_JOIN #639

Closed why-does-ie-still-exist closed 5 years ago

why-does-ie-still-exist commented 5 years ago

Added this code which if the BACKEND is run as 'Zulip' ROOMS_TO_JOIN is updated accordingly. I noticed there's not much code for Zulip(a cursory search shows no matches in the repo). So this will probably make someone's life easier down the line when they port the bot. :sparkles:

Third time's the charm :crossed_fingers:

closes #635

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

why-does-ie-still-exist commented 5 years ago

@jayvdb Sorry to bother you...Why do I have pull request issues?

why-does-ie-still-exist commented 5 years ago

@jayvdb, other than the two chats with the hindi and sindhi script, (which for some reason notepad gets very angry about) I think I've got it :-)

And we should probably leave those two out because unless someone wants to do translation and Unicode surrogate pair parsing, at first the bot'll be in English

We can leave the 'gci-bahasa' though, because those don't use surrogate pairs

why-does-ie-still-exist commented 5 years ago

gotta squash those commits

jayvdb commented 5 years ago

ack https://github.com/coala/corobo/pull/639/commits/302bce4bbe459be5eba12b48dbe7ddcb816ed916

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: