coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

config.py: Blacklist from-somewhere-else user #641

Closed kx-chen closed 5 years ago

kx-chen commented 5 years ago

Blacklisted user from-somewhere-else as it is the IRC bot.

Closes https://github.com/coala/corobo/issues/336

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

jayvdb commented 5 years ago

ack https://github.com/coala/corobo/pull/641/commits/80629870449e4361911ebe6fe630ddda47bb33d7

jayvdb commented 5 years ago

@kx-chen , this one was a bit too easy for you. Where possible, leave the easy ones for new students who are arriving. And if you think the difficulty of a task should be changed, let us know. Sometimes we get it wrong. ;-)

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 5 years ago

@gitmate-bot rebase

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward failed! Please fastforward your pull request manually via the command line.

Reason:

Command: git merge --ff-only head/blacklist-from-somewhere-else

Exit Code: 128

Cause:

fatal: Not possible to fast-forward, aborting.

gitmate-bot commented 5 years ago

Automated rebase with GitMate.io was successful! :tada:

jayvdb commented 5 years ago

reack https://github.com/coala/corobo/pull/641/commits/6c7982dd1ae6ca4834a408cb1273ae4f4f0f1f5c

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: