coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

labhub.py: Add error message when nick is empty #642

Closed abhishalya closed 5 years ago

abhishalya commented 5 years ago

All of the backends do not have nick attribute. Hence an error will be shown whenever nick is empty.

Closes https://github.com/coala/corobo/issues/632

Reviewers Checklist

[x] Appropriate logging is done.
[x] Appropriate error responses.
[x] Handle every possible exception.
[x] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[x] See that 100% coverage is there.
[x] See to it that mocking is not done where it is not necessary.

TravisBuddy commented 5 years ago

Hey @abhishalya, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3756e790-ded6-11e8-9517-3f3b7d8cc1c8

abhishalya commented 5 years ago

I apologize for not checking the code locally. WIll not push until checked :)

abhishalya commented 5 years ago

@nvzard Sure, is this the correct approach though? Do I need to make any changes in the statements?

abhishalya commented 5 years ago

Ping @nvzard @meetmangukiya

abhishalya commented 5 years ago

Btw InvalidLinkBear is complaining:

plugins/ship_it.py
|  14| ········'http://i.imgur.com/DPVM1.png',
|    | [NORMAL] InvalidLinkBear:
|    | Broken link - unable to connect to http://i.imgur.com/DPVM1.png (HTTP Error: 404)

jayvdb commented 5 years ago

ack https://github.com/coala/corobo/pull/642/commits/4c613935607a16a6fd7530ee287f5089326e91bc

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: