coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

Update gitter-backend submodule to latest #648

Closed abhishalya closed 5 years ago

abhishalya commented 5 years ago

This will fix deployment issue with the corobo since the changes are made to the backend.

Closes https://github.com/coala/corobo/issues/647 Fixes https://github.com/coala/corobo/issues/629

Reviewers Checklist

[x] Appropriate logging is done.
[x] Appropriate error responses.
[x] Handle every possible exception.
[x] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[x] See that 100% coverage is there.
[x] See to it that mocking is not done where it is not necessary.

Makman2 commented 5 years ago

coala has detected an issue inside pitchfork.py. The output is pretty intermingled with the debug statements, took me a while to figure it out (using a git grep). The \( in line 28 is indeed an invalid escape sequence and needs to be replaced with two \\.

Makman2 commented 5 years ago

Commit itself is okay.

ack 4eb47fb

Makman2 commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: