coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

config.py: Remove corobo as default prefix #652

Closed sladyn98 closed 5 years ago

sladyn98 commented 5 years ago

Removed corobo as default BOT_PREFIX and added a check for empty BOT_PREFIX

Closes https://github.com/coala/corobo/issues/365

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

sladyn98 commented 5 years ago

@Vamshi99 made the required changes :)

sladyn98 commented 5 years ago

@KVGarg IMHO think we should leave those PR's separate since they are dealing with completely different issues. also our aim would be to get the build green upstream first and then deal with these PR's later. Also we dont have gitmate now :( So these rebases will have to be done manually sigh:/

KVGarg commented 5 years ago

@KVGarg IMHO think we should leave those PR's separate since they are dealing with completely different issues. also our aim would be to get the build green upstream first and then deal with these PR's later. Also we dont have gitmate now :( So these rebases will have to be done manually sigh:/

Ohh, OK 👍🏻