coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

labhub.py: Add private response #657

Closed sladyn98 closed 4 years ago

sladyn98 commented 5 years ago

Added user mentions in labhub commands Added a user mention in lmgtfy plugin as well

Closes https://github.com/coala/corobo/issues/349

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

sladyn98 commented 5 years ago

@Vamshi99 @abhishalya Can you guys kindly give this a look.Thanks

sladyn98 commented 4 years ago

@abhishalya I fixed the tests

abhishalya commented 4 years ago

@abhishalya I fixed the tests

Are you sure?

sladyn98 commented 4 years ago

Yeah pretty sure, do you think something is missing

abhishalya commented 4 years ago

Can you test the @username, changing the case isn't helping much. It would be pretty simple to do since I think we already have examples like those.

sladyn98 commented 4 years ago

@abhishalya I guess the test is self sufficient.