coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!

MIT License

66 stars 103 forks source link

labhub.py: Add duplicate issue title check #658

Closed sladyn98 closed 4 years ago

sladyn98 commented 5 years ago

Added a duplicate issue check to warn the user of a duplicate issue title.

Closes https://github.com/coala/corobo/issues/291

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

abhishalya commented 5 years ago

@sladyn98 Tests?

sladyn98 commented 5 years ago

@abhishalya @Vamshi99 I added some tests I am not very sure if they are correct, could you give me a review

TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: baa8a830-6e38-11e9-b7a6-6b5a2442fe30

TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 21905060-6e6c-11e9-b7a6-6b5a2442fe30

sladyn98 commented 5 years ago

Possible to make an exact title search to avoid too many results?

Actually the title search is being done at iss_title this and the other constraints do allow us to minimize search results

sladyn98 commented 5 years ago

Not necessary to split the string further ;)

Where exactly ?