search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

Add feature to display welcome message with regex #659

Open RohanVB opened 5 years ago

RohanVB commented 5 years ago

For any message such as hello world!, as long as it contains hello world should prompt the welcome message to be displayed

sladyn98 commented 5 years ago

@RohanVB I'm not entirely sure why we would need this :P because we have mentioned in our docs that the message to be posted for help is the wonderful hello world :)

RohanVB commented 5 years ago

Just came across a few users using variations of the expression and thought it'd be useful. People usually explain that they need to type exactly hello world to trigger corobo (including the quotes). Hence the expression with quotes could be removed and everything else containing hello world could be included.

Vamshi99 commented 5 years ago

Yes, Hello world! should be allowed. More than one ! also should be allowed.

sladyn98 commented 5 years ago

@RohanVB Oh understood :+1: @Vamshi99 Just let me get a few of my PR's merged and will get to discussing this :)