search

coala / docker-coala-base

coala base docker image
21 stars 28 forks source link

Dockerfile: Remove fork of gotype #174

Closed Vamshi99 closed 7 years ago

Vamshi99 commented 7 years ago

Remove fork of gotype, as golang.org/x/tools/cmd/gotype package is back again and is go-gettable

jayvdb commented 7 years ago

This breakage is an unrelated problem. could you create a new PR , removing the rpm erase of systemd-presets-branding-openSUSE. That will fix it, and then we can rebase this PR and it should be good.

jayvdb commented 7 years ago

wow ... you pressed the GitHub rebase button? Now we have four commits. (The GitHub rebase button is very silly)

Please do a proper rebase, so we only have to merge one commit.

Vamshi99 commented 7 years ago

@jayvdb No, I didn't pressed rebase button. I was working on master, so something messed while rebasing locally. Anyways, I changed it back to normal 😄

jayvdb commented 7 years ago

ack 6ea69ca

jayvdb commented 7 years ago

@rultor merge

rultor commented 7 years ago

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 7 years ago

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 1min)