coala / docker-coala-base

coala base docker image
21 stars 28 forks source link

Additional bears test fails frequently #224

Open jayvdb opened 7 years ago

jayvdb commented 7 years ago

Some builds are failing in the additional bears test. i.e. using NoCommentsBear here:

https://github.com/coala/docker-coala-base/blob/master/hooks/test#L37

jayvdb commented 7 years ago

See https://travis-ci.org/coala/docker-coala-base/builds/259220329 for an example

(lots of example PRs are being restarted, both on Docker & Travis. With Travis, this restarting means the evidence disappears.)

jayvdb commented 7 years ago

My bet is the cause is https://github.com/coala/coala/pull/4192

jayvdb commented 7 years ago

Raised https://github.com/coala/coala/issues/4613 (PR https://github.com/coala/coala/pull/4614) in the hope that it exposes something.

jayvdb commented 7 years ago

The earliest PR failure I can find is https://travis-ci.org/coala/docker-coala-base/builds/256536397

A good run looks like:

+docker run --volume=/home/travis/build/coala/docker-coala-base/.ci/sample:/work --volume=/home/travis/build/coala/docker-coala-base/.ci/bears:/additional_bears --workdir=/work coala-docker
>> Additional bears directory present, Adding it to additional bear directories
>> Running coala non-interactively ...
[WARNING][01:47:32] Implicit 'Default' section inheritance is deprecated. It will be removed soon. To silence this warning remove settings in the 'Default' section from your coafile. You can use dots to specify inheritance: the section 'all.python' will inherit all settings from 'all'.

**** NoCommentsBear [Section: <empty>] ****

!    ! [Severity: MAJOR]
!    ! Comments are not allowed
[----] /work/hello-world.py
[++++] /work/hello-world.py
[    ] Line affected 1
[    ] 
[----] # This is a subject to test the Docker Image
[INFO][01:47:33] Applied 'ShowPatchAction' on 'hello-world.py' from 'NoCommentsBear'.
[WARNING][01:47:34] Please specify a file naming convention explicitly or use "auto".

A bad run looks like

! docker run --volume=$(pwd)/.ci/sample:/work --volume=$(pwd)/.ci/bears:/additional_bears --workdir=/work coala-docker"
Additional bears directory present, Adding it to additional bear directories
Running coala non-interactively ...
[WARNING][15:58:48] Implicit 'Default' section inheritance is deprecated. It will be removed soon. To silence this warning remove settings in the 'Default' section from your coafile. You can use dots to specify inheritance: the section 'all.python' will inherit all settings from 'all'.

**** NoCommentsBear [Section: <empty>] ****

!    ! [Severity: MAJOR]
!    ! Comments are not allowed
[----] /work/hello-world.py
[++++] /work/hello-world.py
[    ] Line affected 1
[    ] 
[----] # This is a subject to test the Docker Image
[INFO][15:58:49] Applied 'ShowPatchAction' on 'hello-world.py' from 'NoCommentsBear'.
[WARNING][15:58:50] Please specify a file naming convention explicitly or use "auto".

Note that around this time 6f0b5b90ee occurred, so maybe that is also related.

jayvdb commented 7 years ago

ugh. https://travis-ci.org/jayvdb/docker-coala-base/builds/261254162 is failing earlier, in the first quickstart generated coala-ci run.

jayvdb commented 7 years ago

A good run, with --verbose enabled, looks like https://travis-ci.org/jayvdb/docker-coala-base/builds/261455148