search

coala / gci-leaders

A website showing Google Code-in information 🏆
https://gci-leaders.netlify.com
39 stars 45 forks source link

Main.css: Fix broken social link Fixes https://github.com/coala/gci-leaders/issues/73 #142

Closed mvinoba closed 6 years ago

mvinoba commented 6 years ago

Fixes #73 using @wisn suggestion.

mvinoba commented 6 years ago

@newbazz What would be the appropriate changes to the commit? This is my first PR, I apologise any mistake on common guidelines.

blazeu commented 6 years ago

You forgot to put Fixes https://github.com/coala/gci-leaders/issues/73 on your commit body

mvinoba commented 6 years ago

@newbazz Not sure if it's done right now or if it should be just #73 to reference the issue on commit message.

newbazz commented 6 years ago

in two different line

mvinoba commented 6 years ago

@newbazz Thanks! Please check if it's correct now, apparently I mistook the PR title with the commit message.

blazeu commented 6 years ago

coala says:

|    | [NORMAL] GitCommitBear:
|    | No newline found between shortlog and body at HEAD commit. Please add one.

Your commit needs to be like this

Main.css: Fix broken social link

Fixes https://github.com/coala/gci-leaders/issues/73

1 newline between shortlog and body.

mvinoba commented 6 years ago

@newbazz It should be ok now, GitCommitBear ran without warnings.

mvinoba commented 6 years ago

I implemented wisn's suggestion, the one that made the issue a newcomer one, but perhaps there are better ways to solve this issue.

blazeu commented 6 years ago

ack https://github.com/coala/gci-leaders/pull/142/commits/5fe816cf49d2f6d4360c86c86b4402e0b5fede63

blazeu commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: