search

coala / gci-leaders

A website showing Google Code-in information 🏆
https://gci-leaders.netlify.com
39 stars 45 forks source link

Changed Haiku's wikidata url #143

Closed apoorvaagupta closed 6 years ago

apoorvaagupta commented 6 years ago

Signed-off-by: Apoorvaa Gupta apoorvaagupta01@gmail.com

Fixes #123

apoorvaagupta commented 6 years ago

Hello @Makman2 I have just replaced the wrong wikidata url with the correct one in the data.min.json file on gh-pages branch. But this is showing some error in deploying thought I haven't changes any other file. Please help!!

apoorvaagupta commented 6 years ago

Hello, @newbazz Can you please tell me my mistake?! I am new to coala!

ishanSrt commented 6 years ago

@apoorvaagupta did you go through the newcomer's guide? anyways here are the commit guidelines: https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

ishanSrt commented 6 years ago

Seriously what are the changes that you made?

screen shot 2018-02-04 at 2 30 35 am
ishanSrt commented 6 years ago

Does gitmate not check for the proper phrasing of commit messages? @newbazz what I mean is division of shortlog and/or body and last line

jayvdb commented 6 years ago

Changing the data file is not the correct solution.