Closed li-boxuan closed 6 years ago
I notice that JBoss has two linked on https://gci-leaders.netlify.com/ , but none on https://deploy-preview-148--gci-leaders.netlify.com/ .
@jayvdb I just investigated that problem (JBoss has no link).
This is not due to this PR; I use the previous HEAD to build and also found no link on JBoss part.
This is because of the name of their gitter room: this link https://gitter.im/jboss-outreach/gci (See #258, which makes use of that link to extract their org name).
However, their org name should be JBossOutreach
instead of jboss-outreach
. That's why two links are missing. Btw, https://gitter.im/jboss-outreach/gci would automatically jump into https://gitter.im/JBossOutreach/gci, which is indeed what we want.
I added the following code around line #272 and ran it on my machine: JBoss would now again have two links.
if (orgFromWebsites === 'jboss-outreach') {
return 'JBossOutreach'
}
Do you have some advice what I should do to fix this problem? Visit every link and see if it would jump to some other link? Or add ad-hoc support for JBossOutreach
?
fwiw, a part of the problem was that https://github.com/coala/gci-leaders/commit/92a68a288c490adc2c2d2ef2854dba982d41db21 cleared out all of the data in the deploy.
We dont need a special case for JBoss. The link in GCI is old, but a head request will give us the new URL.
That is needed for any github/gitter URL which changes. That should be a new PR which just fixes master.
It would be good to finish this up, as I suspect we will need this in order to do https://github.com/coala/gci-leaders/issues/165 , and possible also https://github.com/coala/gci-leaders/issues/164
Lots of "Cannot fetch org x from GitHub, error message: unknown error" in the log https://travis-ci.org/coala/gci-leaders/builds/447609704
Lots of "Cannot fetch org x from GitHub, error message: unknown error" in the log
Weird, it works fine on my local machine. The log should be sth as follows:
Cannot fetch user xxx from GitHub, error message: Could not resolve to a User with the login of 'xxx'.
IIRC the number of unauthenticated GraphQL requests you get is lower than normal API hits. Since this is a PR, I think Travis removes the GH_TOKEN
env variable for security reasons, so all the GraphQL requests are made unauthenticated. Might be why it is unable to fetch users after a certain point?
Hey @li-boxuan, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
@gitmate-bot ff
Use GitHub GraphQL API instead of REST API
closes https://github.com/coala/gci-leaders/issues/111