search

coala / gci-leaders

A website showing Google Code-in information 🏆
https://gci-leaders.netlify.com
39 stars 45 forks source link

rss.js: Fix TypeError for undefined oldData #152

Closed hizkifw closed 6 years ago

hizkifw commented 6 years ago

Fixes #150

bekicot commented 6 years ago

This is could be the fix. I would also recommend updating the corresponding test.

My personal preference is to log a warning whenever the oldData is null or undefined. As it should not be empty.

cc @andrewda && @blazeu for that. It is maybe not a good idea to log a warning.

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: