coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

Enhance meta-review UI #128

Closed li-boxuan closed 5 years ago

li-boxuan commented 5 years ago

Related to https://github.com/coala/gh-board/issues/84

li-boxuan commented 5 years ago

Regarding enhancement 2 mentioned in https://github.com/coala/gh-board/issues/84#issuecomment-406809509,

this would be handled later in a separate pr (ability to do meta-reviews directly on gh-board)

li-boxuan commented 5 years ago

Preview:

jietu20180728-174935

hemangsk commented 5 years ago
  1. Some space between the emoji button row and the "Import igitt data" div

    screen shot 2018-07-29 at 01 38 28
  2. emoji size needs to grow a bit more

    screen shot 2018-07-29 at 01 39 12
li-boxuan commented 5 years ago

Preview after update:

jietu20180729-113737

hemangsk commented 5 years ago

ack 83fc25d477fefaeba6d1293ccb71bbd21df0e444

jayvdb commented 5 years ago

@gitmate-bot rebase

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated rebase with GitMate.io was successful! :tada:

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @li-boxuan, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: undefined

npm run test ``` > gh-board@0.0.0 test /home/travis/build/coala/gh-board > ./script/run-test.sh +script/verify-files.sh +files=("issues.json" "recent-issues.json") +for file in '"${files[@]}"' +[[ -f issues.json ]] +echo 'File issues.json exists.' File issues.json exists. +for file in '"${files[@]}"' +[[ -f recent-issues.json ]] +echo 'File recent-issues.json exists.' File recent-issues.json exists. ++npm bin +/home/travis/build/coala/gh-board/node_modules/.bin/jest FAIL test/src/components/reactions.test.js ✕ does not display number zero (32ms) ● does not display number zero expect(value).toMatchSnapshot() Received value does not match stored snapshot "does not display number zero 1". - Snapshot + Received @@ -1,48 +1,48 @@ Array [ , , , , ,
jayvdb commented 5 years ago

ack https://github.com/coala/gh-board/pull/128/commits/d1a7ea3ea66c7af7a51a9717f67fc635fc35cf41

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: