search

coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

meta-review ignore content has wrong regular expression #149

Closed li-boxuan closed 6 years ago

li-boxuan commented 6 years ago

https://github.com/coala/gh-board/blob/d1a7ea3ea66c7af7a51a9717f67fc635fc35cf41/src/github-client.js#L226 https://github.com/coala/gh-board/blob/d1a7ea3ea66c7af7a51a9717f67fc635fc35cf41/script/fetch-issues.js#L34

Should be

^(ack|unack)

instead.

See difference:

> 'ack 123'.match(/^(ack|unack)/g)
[ 'ack' ]
> 'ack 123'.match('/^(ack|unack)/g')
null
> 'ack 123'.match('^(ack|unack)')
[ 'ack', 'ack', index: 0, input: 'ack 123' ]
li-boxuan commented 6 years ago

Also https://github.com/coala/gh-board/blob/d1a7ea3ea66c7af7a51a9717f67fc635fc35cf41/script/fetch-issues.js#L28 TravisBuddy should also be there.