coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

Remove unnecessary parameter #162

Closed aditya81070 closed 5 years ago

aditya81070 commented 6 years ago

fixes #137

PrajwalM2212 commented 6 years ago

@aditya81070 You need to follow the commit guidelines http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html Also your pull request does not indicate the issue you are solving.

aditya81070 commented 6 years ago

@PrajwalM2212 I will improve this in the future. Should I also change commit message for this time?

PrajwalM2212 commented 6 years ago

@aditya81070 You would be on the safer side if you changed your commit this time itself . I don't think they will merge the PR until commit message is changed. git commit --amend -m "shortlog" -m "commit body" -m "issue reference" You can refer http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html on how to write shortlog, body and reference, but using the command that i gave you should do the job.

aditya81070 commented 6 years ago

@PrajwalM2212 I have changed the commit message.

aditya81070 commented 6 years ago

@srivama @rishabhgarg25699 @PrajwalM2212 I have squashed three commits to one and also changed commit messages according to the Coala guidelines.

aditya81070 commented 6 years ago

@li-boxuan I did the commit message according to the guide.

aditya81070 commented 6 years ago

@li-boxuan What should I do now?

aditya81070 commented 6 years ago

@li-boxuan I have changed the commit message

li-boxuan commented 6 years ago

This is not a bug so you should use Closes instead of Fixes.

li-boxuan commented 6 years ago

@aditya81070 Are you still doing this?

jayvdb commented 6 years ago

@aditya81070 , needs a manual rebase to resolve conflicts

See https://coala.io/git

aditya81070 commented 6 years ago

@jayvdb Okay I am doing this.

jayvdb commented 5 years ago

Abandoned.