Closed aditya81070 closed 5 years ago
@aditya81070 You need to follow the commit guidelines http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html Also your pull request does not indicate the issue you are solving.
@PrajwalM2212 I will improve this in the future. Should I also change commit message for this time?
@aditya81070 You would be on the safer side if you changed your commit this time itself . I don't think they will merge the PR until commit message is changed.
git commit --amend -m "shortlog" -m "commit body" -m "issue reference"
You can refer http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html on how to write shortlog, body and reference, but using the command that i gave you should do the job.
@PrajwalM2212 I have changed the commit message.
@srivama @rishabhgarg25699 @PrajwalM2212 I have squashed three commits to one and also changed commit messages according to the Coala guidelines.
@li-boxuan I did the commit message according to the guide.
@li-boxuan What should I do now?
@li-boxuan I have changed the commit message
This is not a bug so you should use Closes
instead of Fixes
.
@aditya81070 Are you still doing this?
@aditya81070 , needs a manual rebase to resolve conflicts
@jayvdb Okay I am doing this.
Abandoned.
fixes #137