search

coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

router.jsx: browserHistory is mistakenly used #163

Closed li-boxuan closed 5 years ago

li-boxuan commented 6 years ago

https://github.com/coala/gh-board/commit/32337460bfb1ee16bbdf6672dd3a6fe108a66ac4 was trying to fix the dashboard navigation problem, but the fix was not perfect.

We should not use browserHistory at https://github.com/coala/gh-board/blob/32337460bfb1ee16bbdf6672dd3a6fe108a66ac4/src/router.jsx#L30 but history instead, which has been defined at https://github.com/coala/gh-board/blob/f08f19b70cd233a889c9df7c507e0532686020a0/src/router.jsx#L5

c.f. https://github.com/coala/gh-board/pull/162#discussion_r220439270

li-boxuan commented 6 years ago

To see why this is a problem, go to https://coala-gh-board.netlify.com. If you click on the dashboard icon (on top left), it would work. However, if you right click and open it in another page, it would go to https://coala-gh-board.netlify.com without the hashtag and the page would not be correctly loaded.

bhawesh96 commented 6 years ago

Please assign this issue to me. Submitted at PR #164