coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

Include /src/lib directory in git #165

Closed jkosh44 closed 5 years ago

jkosh44 commented 5 years ago

Adds rule to .gitignore and .moban.dt/gh-board-gitignore.jj2 to explicitly include the /src/lib folder in all git commits.

Fixes https://github.com/coala/gh-board/issues/50

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 55794920-c987-11e8-a6c9-11724a02104f
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b9165b00-c98a-11e8-a6c9-11724a02104f
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9d867800-c98c-11e8-a6c9-11724a02104f
jkosh44 commented 5 years ago

Honestly not very familiar with moban, can someone explain the issue here?

li-boxuan commented 5 years ago

Hi, please ask maintainers to assign you to the issue first, if you haven’t done so. Do not open an issue without assignment, unless you have claimed on the issue page that you want to do it, and there is neither active pull request nor someone else who claimed before you.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d5a996a0-ca6c-11e8-bd56-bd6e450aa6f6
jkosh44 commented 5 years ago

I'm opening up a new pull-request because my local repo got pretty messed up in my attempt to squash all the commits.

li-boxuan commented 5 years ago

To use Git properly is a basic requirement for all contributors. local repo got pretty messed up in my attempt to squash all the commits. is not an excuse.

jkosh44 commented 5 years ago

I think because I deleted my branch it's no longer allowing me to make pushes to this PR. I'm going to go ahead and abandon this.

li-boxuan commented 5 years ago

Alright, anyway please don't close PR anymore. And do not delete your branch unless your PR gets merged.