search

coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

Include /src/lib directory in git #166

Closed jkosh44 closed 5 years ago

jkosh44 commented 5 years ago

Adds rule to .gitignore and .moban.dt/gh-board-gitignore.jj2 to explicitly include the /src/lib folder in all git commits.

Closes https://github.com/coala/gh-board/issues/50

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0b539dd0-ca6f-11e8-bd56-bd6e450aa6f6
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 635d9500-ca72-11e8-bd56-bd6e450aa6f6
jkosh44 commented 5 years ago

Still not passing even though I have identical lines in both .gitignore and gh-board-gitignore.jj2. Also don't really like hard coding column.js in there because the issue will exist on any other files added to the lib folder.

li-boxuan commented 5 years ago

Please close this and reopen your previous PR https://github.com/coala/gh-board/pull/165.

Please read http://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-6-waiting-for-review. Never close a Pull Request unless you are told to do so.. When doing so, you are destroying reviewers' work and people might waste time on something that others have already reviewed.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jkosh44, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b3b83ec0-ca9e-11e8-bd56-bd6e450aa6f6