search

coala / gh-board

:octocat: Kanban for GitHub Issues
https://coala-gh-board.netlify.com/
GNU Affero General Public License v3.0
21 stars 25 forks source link

API limit exceed: Show modal #184

Open 123vivekr opened 5 years ago

123vivekr commented 5 years ago

Shows the error in a user friendly way.

Closes https://github.com/coala/gh-board/issues/127

wisn commented 5 years ago

@jayvdb @blazeu which JavaScript style guide we use for this repository? Is it Airbnb? I would like to review this pull request.

li-boxuan commented 5 years ago

We didn't specify or regulate a javascript style, but airbnb style seems to be the thing we were actually practicing.

123vivekr commented 5 years ago

@wisn Thank you for reviewing my Pull Request. I will change my code to follow the airbnb style guide.

This is the modal. 20190117_100548

I'm having problem with the state to toggle the visibility of the modal. I am not able to update state within static defaultProps object. Please guide me on what changes I have to make here. Consequently, the Ok button does not do anything.

PS: Please ignore the dark theme

123vivekr commented 5 years ago

I've made the requested changes - changed space indentation to 2 spaces and changed const {identifier} to const { identifier }

123vivekr commented 5 years ago

@wisn Please review my PR

wisn commented 5 years ago

@123vivekr Does the modal works now? I don't know why the deploy preview always failed

123vivekr commented 5 years ago

@wisn I changed the props to functions and gave a show variable in the state. But the onResolve and onError functions are called (which in turn calls setState) multiple times and causes an infinite loop.

123vivekr commented 5 years ago

@wisn Please help figure out the cause of multiple calls to onError and onResolve.

jayvdb commented 5 years ago

@gitmate-bot rebase

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated rebase with GitMate.io was successful! :tada:

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7c20ed10-278f-11e9-81eb-21ccd9c7497f
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d0613370-27d1-11e9-81eb-21ccd9c7497f
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 49629480-27d7-11e9-81eb-21ccd9c7497f
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 167fa660-2c24-11e9-b5fe-e1edd527e2d3
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d6fdf350-2c25-11e9-b3d3-256864349aa7
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fc846d20-2c25-11e9-b3d3-256864349aa7
123vivekr commented 5 years ago

20190210_211950 This is the final modal.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fb35e080-2d4b-11e9-bee6-ebd77371f46a
KVGarg commented 5 years ago

@123vivekr I have no knowledge regarding react language, but regarding coding standards I have one question. Since, the code is getting repeated at 1 and 2. So, can we create a single function for it that contains the repeated code and it accepts the args/kwargs for the content which is getting changed i.e. of paragraph, header etc. If that is possible it will be much good.

123vivekr commented 5 years ago

@KVGarg Requested changes have been made. :) Thank you for the suggestion

KVGarg commented 5 years ago

Also, haven't notices the number of commits before, sorry. Last change, Please squash your commits. After that :100:

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a2b85b70-2d52-11e9-bee6-ebd77371f46a
123vivekr commented 5 years ago

@KVGarg The commits are for different changes in different files. I don't think they need to be squashed. Thank you for reviewing.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e2ea4b00-2e69-11e9-93d2-519d0ef52680
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3bba9f70-2e6d-11e9-93d2-519d0ef52680
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 183d46a0-2e6e-11e9-93d2-519d0ef52680
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6a3eeda0-2e6e-11e9-93d2-519d0ef52680
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @123vivekr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b5167960-2e6e-11e9-93d2-519d0ef52680