router.jsx: Remove unused state & replace parameter

coala / gh-board

:octocat: Kanban for GitHub Issues

https://coala-gh-board.netlify.com/

GNU Affero General Public License v3.0

21 stars 25 forks source link

router.jsx: Remove unused state & replace parameter #187

Open GeniusLearner opened 5 years ago

GeniusLearner commented 5 years ago

The two arguments state and replace in onEnter are not required. In the route when /dashboard matches, it is directed to / using browserHistory.push().

Closes https://github.com/coala/gh-board/issues/137

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @GeniusLearner, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3a260c30-d241-11e9-96c5-8bf35d42f9db

RJ722 commented 5 years ago

Thanks for the contribution @GeniusLearner. Don't worry, the CI build failing looks unrelated to this issues. (same with #184).

Hey @li-boxuan, can you help us out here, please?

GeniusLearner commented 5 years ago

Hi @RJ722 , any update on this?

li-boxuan commented 5 years ago

We need moban sync to let Travis pass first.