snippets.js: Move Lua snippet to follow JSON

jsecrest commented 6 years ago

This makes the dropdown list alphabetical

Closes https://github.com/coala/landing-frontend/issues/276

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

[x] I read the commit guidelines and I've followed them.
[x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

jsecrest commented 6 years ago

I've amended my commit to include the full stop as requested by li-boxuan

LGTM, a tiny change to go - could you add a full stop in your commit message. This makes the dropdown list alphabetical -> This makes the dropdown list alphabetical.

jsecrest commented 6 years ago

I have added the trailing comma to the end of the list as requested. This pleases many contributors who like trailing commas and also prevents the unneeded line addition diff.

I also note that our commit documentation suggests that "If an issue is labelled with type/bug you should always use Fixes. For all other issues use Closes." As the label "type/bug" is on this issue I have changed "closes" to "fixes" in my commit.

jayvdb commented 6 years ago

Ack 500a0d7

jayvdb commented 6 years ago

@gitmate-bot ff

jayvdb commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada:

coala / landing-frontend

snippets.js: Move Lua snippet to follow JSON #278

Checklist