coala / landing-frontend

coala Landing Page - https://gitlab.com/coala/landing is needed as backend
https://coala.io/
GNU Affero General Public License v3.0
32 stars 74 forks source link

Make copyright year dynamic in coala.io #291

Closed Vaibhav911 closed 6 years ago

Vaibhav911 commented 6 years ago

This entrypoint ensures copyright year in foot of coala.io updates every year automatically. This helps in not updating the same every year. Closes https://github.com/coala/landing-frontend/issues/290

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @Vaibhav911, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... Executing section linecount... Executing section spacing... | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - Trailing whitespaces. |----| | /app/includes/footer.html | |++++| /app/includes/footer.html | 60| 60|
| 61| 61|
Vaibhav911 commented 6 years ago

Can someone clarify why it is showing this PR has issues? I have removed all the trailing white spaces.

Tyroc commented 6 years ago

Can't really help with the whitespace problem, but I think that the code in itself is not working. If i try your exact solution, my whole page gets overwritten and only the new Date is being displayed. However in the following solution everything works fine:

<span class="left">
    &copy;
    <span id="copyright">
        <script>document.getElementById('copyright').appendChild(document.createTextNode(new Date().getFullYear()))</script>
    </span>
    coala
</span>

Maybe try that.

Vaibhav911 commented 6 years ago

@Tyroc Thnx for your suggestion. But your code is producing same output as mine in my machine. I have just changed the year part of the code. Rest html page is still the same. I don't know why your whole page is being overwritten with my code. Please correct me if I am wrong anywhere. Thnx once again.

Tyroc commented 6 years ago

@Vaibhav911 Then there must be a problem with my machine. Sorry! Good contribution btw.

Vaibhav911 commented 6 years ago

@Tyroc, I guess you were right. if I run document.write after the document has loaded ,it overwrite the whole page. If it is run before that, it does not overwrite it. So I am using a little different approach now. Thank you so much for pointing out my mistake. I will correct it soon.

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @Vaibhav911, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... Executing section linecount... Executing section spacing... | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - Tabs used instead of spaces. |----| | /app/includes/footer.html | |++++| /app/includes/footer.html | 61| 61|
TravisBuddy Request Identifier: d479d040-da72-11e8-8964-ad637cdcaaf8
srivama commented 6 years ago

Run coala on your code locally before making a push.

Vaibhav911 commented 6 years ago

Sorry, I will take care of this from next time. Now I have tested the code completely and it's working fine. I am about to squash it.

jayvdb commented 6 years ago
jayvdb commented 6 years ago

@gitmate-bot ff

jayvdb commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: