Closed Vaibhav911 closed 6 years ago
Hey @Vaibhav911, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Can someone clarify why it is showing this PR has issues? I have removed all the trailing white spaces.
Can't really help with the whitespace problem, but I think that the code in itself is not working. If i try your exact solution, my whole page gets overwritten and only the new Date is being displayed. However in the following solution everything works fine:
<span class="left">
©
<span id="copyright">
<script>document.getElementById('copyright').appendChild(document.createTextNode(new Date().getFullYear()))</script>
</span>
coala
</span>
Maybe try that.
@Tyroc Thnx for your suggestion. But your code is producing same output as mine in my machine. I have just changed the year part of the code. Rest html page is still the same. I don't know why your whole page is being overwritten with my code. Please correct me if I am wrong anywhere. Thnx once again.
@Vaibhav911 Then there must be a problem with my machine. Sorry! Good contribution btw.
@Tyroc, I guess you were right. if I run document.write after the document has loaded ,it overwrite the whole page. If it is run before that, it does not overwrite it. So I am using a little different approach now. Thank you so much for pointing out my mistake. I will correct it soon.
Hey @Vaibhav911, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
This entrypoint ensures copyright year in foot of coala.io updates every year automatically. This helps in not updating the same every year. Closes https://github.com/coala/landing-frontend/issues/290