Animation Under All Tabs are Working

AkshJain99 commented 5 years ago

Highlighting animation are working under all tabs on navigation between different tabs.

Fixes https://github.com/coala/landing-frontend/issues/295

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

[x] I read the commit guidelines and I've followed them.
[x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

AkshJain99 commented 5 years ago

ya but people.html is somewhere which also have this problem so maybe it is right I will look again

AkshJain99 commented 5 years ago

@hemangsk please revirew this pr

AkshJain99 commented 5 years ago

@li-boxuan please take look at this pr

hemangsk commented 5 years ago

Is there any way to avoid the code duplication, maybe adding it by in index.html file ?

AkshJain99 commented 5 years ago

@hemangsk I tried to do so in index.html but I dont think that we will be able to do that . Do we? And its just 2 line of code that has been added I dont think that it is affecting the codes,Is it? :sweat_smile:

AkshJain99 commented 5 years ago

@hemangsk I tried adding the script in index.html but then it doesn't work, but code which I committed is working well :sweat_smile:

hemangsk commented 5 years ago

Ya I understand, Two lines or one lines is not the point, duplication makes maintaining it difficult. Otherwise, this lgtm.

AkshJain99 commented 5 years ago

okay @hemangsk I am understanding, then should i need to change something in code?

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @AkshJain99, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... Executing section linecount... Executing section spacing... | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - No newline at EOF. |----| | /app/partials/tabs/home.html | |++++| /app/partials/tabs/home.html | 136| 136| $('ul.tabs').tabs(); | 137| 137| }); | 138| 138| | 139| |- | | 139|+ [INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/home.html' from 'SpaceConsistencyBear'. | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - No newline at EOF. |----| | /app/partials/tabs/getinvolved.html | |++++| /app/partials/tabs/getinvolved.html | 82| 82| $('ul.tabs').tabs(); | 83| 83| }); | 84| 84| | 85| |- | | 85|+ [INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/getinvolved.html' from 'SpaceConsistencyBear'. | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - No newline at EOF. |----| | /app/partials/tabs/coalaonline.html | |++++| /app/partials/tabs/coalaonline.html | 279| 279| $('ul.tabs').tabs(); | 280| 280| }); | 281| 281| | 282| |- | | 282|+ [INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/coalaonline.html' from 'SpaceConsistencyBear'. | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - No newline at EOF. |----| | /app/partials/tabs/languages.html | |++++| /app/partials/tabs/languages.html | 220| 220| $('.tooltipped').tooltip({delay: 50}); | 221| 221| | 222| 222| }) | 223| |- | | 223|+ [INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/languages.html' from 'SpaceConsistencyBear'. | | [NORMAL] SpaceConsistencyBear: | | Line contains following spacing inconsistencies: | | - No newline at EOF. |----| | /app/partials/tabs/about.html | |++++| /app/partials/tabs/about.html | 129| 129| $('ul.tabs').tabs(); | 130| 130| }); | 131| 131| | 132| |- | | 132|+ [INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/about.html' from 'SpaceConsistencyBear'. Executing section html... Executing section yml... Executing section cli... ```

TravisBuddy Request Identifier: a48c5d40-0212-11e9-819e-e174a5d00ea5

hemangsk commented 5 years ago

ack 88f354e

AkshJain99 commented 5 years ago

thanks @hemangsk , when it can be merge now? and please if possible do review this https://github.com/coala/landing-frontend/pull/296 too as it has somwehat same content for "project" repo

Makman2 commented 5 years ago

@gitmate-bot ff

jayvdb commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada:

coala / landing-frontend