search

coala / meta

A repository for non-code activities, such as engagement initiatives, and other meta issues
6 stars 5 forks source link

Enable travis-buddy on GitHub repos #114

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

https://github.com/bluzi/travis-buddy provides a synopsis of the travis error on the pull request

https://travisbuddy.com

jayvdb commented 6 years ago

I would suggest the following order

  1. https://github.com/coala/documentation
  2. https://github.com/coala/cEPs
  3. https://github.com/coala/corobo
  4. https://github.com/coala/coala-vs-code
  5. https://github.com/coala/projects
  6. https://github.com/coala/coala-html
  7. https://github.com/coala/community
  8. https://github.com/coala/coala-bears

And after each we check that it is working as expected before continuing to the next.

manankalra commented 6 years ago

There should be individual issues opened for this in the corresponding repos or just this issue should be referenced in the individual PRs?

jayvdb commented 6 years ago

No need, just use Related to https://github.com/coala/meta/issues/114

palash25 commented 6 years ago

Can this issue have multiple assignee? I think we can complete it much faster if we divide individual repos amongst ourselves. If you don't mind @manankalra .

cc @jayvdb

jayvdb commented 6 years ago

Please read the issue again @palash25 .

jayvdb commented 6 years ago

Another option is to enable travieso

maybe we try that after travis-buddy, if we dont like travis-buddy.

c.f. https://github.com/coala/coala/issues/4891

manankalra commented 6 years ago

travis isn't set up for cEPs; needed?

jayvdb commented 6 years ago

https://github.com/coala/documentation/pull/555#issuecomment-385757936 - a buddy error. looks nice!

travis isn't set up for cEPs; needed?

ok, skip that one for now.

manankalra commented 6 years ago

For corobo: As per my knowledge, https://github.com/travis-ci/travis-ci/issues/5121 isn't solved yet. Also, the docs do not mention anything of this sort - https://docs.travis-ci.com/user/notifications/#Configuring-webhook-notifications.

Will have to omit on_success: never for now.

jayvdb commented 6 years ago

Before doing bears, here are some more to give us some experience with it

  1. https://github.com/coala/coala-quickstart
  2. https://github.com/coala/gci-leaders
  3. https://github.com/coala/gh-board
  4. https://github.com/coala/coala-emacs
  5. https://github.com/coala/landing-frontend
manankalra commented 6 years ago

Should I open PRs for all of them? There seems to be no ongoing contribution activities in any of the above repos (other than gh-board). Shouldn't we first test it on coala-bears then?

bluzi commented 6 years ago

Hey guys,

It looks like you've been using TravisBuddy for more than a month now, so I was just wondering if there's anything you think we can improve or add?

jayvdb commented 6 years ago

Interesting missing error at https://github.com/coala/corobo/pull/550#issuecomment-395577123

manankalra commented 6 years ago

Here, too. - https://github.com/coala/corobo/pull/552

li-boxuan commented 6 years ago

TravisBuddy copies too much log. 😕 That's a lot of network traffic, especially when we use API to fetch comments.

jayvdb commented 6 years ago

Probably https://github.com/bluzi/travis-buddy/issues/109 @bluzi

Also some feature requests https://github.com/bluzi/travis-buddy/issues/created_by/jayvdb

@li-boxuan , can you link to some large comments. @bluzi may know how to fix them.

li-boxuan commented 6 years ago

This is a large comment: https://github.com/coala/community/pull/143#issuecomment-395946259

jayvdb commented 6 years ago

Any large comments in JS projects?

TravisBuddy doesnt have code for python specific projects yet.

bluzi commented 6 years ago

Thanks a lot guys! that's super helpful!

Interesting missing error at coala/corobo#550 (comment)

Here, too. - coala/corobo#552

Thanks, will definitely look into it

Also some feature requests https://github.com/bluzi/travis-buddy/issues/created_by/jayvdb

Awesome, thank you!

This is a large comment: coala/community#143 (comment)

Definitely a bug, TravisBuddy should break the log using the scripts supplied in .travis.yml. Instead this comment contains the entire raw log. Will look into it and get back to you.

li-boxuan commented 6 years ago

Not sure if this is also a 'large' comment (JS project) https://github.com/coala/gci-leaders/pull/149#issuecomment-386820394

bluzi commented 6 years ago

Not sure if this is also a 'large' comment (JS project) coala/gci-leaders#149 (comment)

Nope. As you can see in the build log, the raw log is a lot bigger. TravisBuddy extracted the log of the executed command (npm run build), so that's by design.

jayvdb commented 5 years ago

@manankalra , any active repos left to enable this in?

manankalra commented 5 years ago

Yes. coala and coala-bears.