search

coala / meta

A repository for non-code activities, such as engagement initiatives, and other meta issues
6 stars 5 forks source link

authorPatchCollector.py: Add GSOC patch collector #126

Closed srivama closed 6 years ago

srivama commented 6 years ago

Closes https://github.com/coala/meta/issues/124

srivama commented 6 years ago

@palash25 PTAL :)

srivama commented 6 years ago

@li-boxuan PTAL :) I've already ran the common bears on the script :wink:

li-boxuan commented 6 years ago

Can you also run LineLengthBear?

srivama commented 6 years ago

@li-boxuan Done :wink:

li-boxuan commented 6 years ago

As https://github.com/coala/meta/issues/124#issue-349366798 points out, @MacBox7 reported problems using it. @nkprince007 also encountered problems. I guess we need to verify whether this PR solves these problems.

Btw I also used the original shell script but I didn't encountered any problem, so I am not sure what the problem is 😅

srivama commented 6 years ago

@li-boxuan Sure thing! @MacBox7, @nkprince007 PTAL :)

jayvdb commented 6 years ago

You can test it yourself. Use their username, and try to recreate their gsoc patch set, and it should look like their final output, e.g. at http://projects.coala.io/GSoC/2018/StatusReport/macbox7

srivama commented 6 years ago

Checked with 'MacBox7' on coala and coala-bears, it's working :wink: It'll be good though, if we get to know the exact problem they faced.

srivama commented 6 years ago

@jayvdb The script is working on all repos mentioned by @MacBox7, except for PyPrint. The commits made in PyPrint have somehow stored author as 'macbox7' instead of 'MacBox7', because of which git --author isn't able to fetch them.

srivama commented 6 years ago

Please move this tool to https://github.com/coala/projects

@jayvdb Directly in projects or in some sub?

jayvdb commented 6 years ago

In a subdirectory somewhere, probably. Make a best guess at what is appropriate. We can then review that guess in the PR ;-)