Closed coala-bot closed 7 years ago
Thanks for your contribution!
Reviewing pull requests take a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
Fixes
keyword if the commit fixes a real bug and the Closes
keyword if it adds a feature/enhancement. See more here.As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!
I did this manually on the db because of some auth issue: update git_hub_repository set autorespond_text="Thanks for your contribution!\n\nReviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.\n\n- [ ] I have rebased properly. [Please see this for a tutorial.](http://coala.readthedocs.io/en/latest/Developers/Git_Basics.html#rebasing)\n- [ ] I have gone through the [commit guidelines](http://coala.readthedocs.io/en/latest/Developers/Writing_Good_Commits.html) and I've followed them:\n - [ ] I have followed the [guidelines for the commit shortlog](http://docs.coala.io/en/latest/Developers/Writing_Good_Commits.html#shortlog).\n - [ ] I have followed the [guidelines for the commit body](http://docs.coala.io/en/latest/Developers/Writing_Good_Commits.html#commit-body).\n - [ ] I have included the issue URL.\n - [ ] I have used the
Fixeskeyword if the commit fixes a *real bug* and the
Closeskeyword if it adds a feature/enhancement. [See more here.](http://docs.coala.io/en/latest/Developers/Writing_Good_Commits.html#issue-reference)\n- [ ] I have [run all the tests](http://coala.readthedocs.io/en/latest/Developers/Executing_Tests.html) and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!\n\nAs you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!" where full_name LIKE "coala/%";
I filed an issue in documentation about that one and the rest is done.
Updated it a bit:
update git_hub_repository set autorespond_text="Thanks for your contribution!\n\nReviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.\n\n- I have rebased properly. [Please see this for a tutorial.](https://coala.io/git#rebasing)\n- I have gone through the [commit guidelines](https://coala.io/commit) and I've followed them:\n - I have followed the [guidelines for the commit shortlog](https://coala.io/commit#shortlog).\n - I have followed the [guidelines for the commit body](https://coala.io/commit#commit-body).\n - I have included the issue URL.\n - I have used the `Fixes` keyword if the commit fixes a *real bug* and the `Closes` keyword if it adds a feature/enhancement. [See more here.](https://coala.io/commit#issue-reference)\n- I have [run all the tests](http://api.coala.io/en/latest/Developers/Executing_Tests.html) and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!\n\nAs you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!" where full_name LIKE "coala/%";
Please scroll up the discussion as linked by cobot.
Opened via gitter by @sils