search

coala / meta

A repository for non-code activities, such as engagement initiatives, and other meta issues
6 stars 5 forks source link

Auto close PRs after some time of inactivity #83

Open meetmangukiya opened 7 years ago

meetmangukiya commented 7 years ago

As of now we have 130+ PRs on coala and 70+ in coala-bears. Most of them are inactive I think. But for new contributors it might occur that either the community is not reviewing much. I think it can have a negative effect, maybe?

Makman2 commented 7 years ago

Maybe we should just bust them ourselves. Maybe we need a new PR buster team ;P

I don't wanna lose those PRs, some of the authors have really put some work into those.

SanketDG commented 7 years ago

^ Agree 100%, closing PRs is never the solution. Inactivity can be of various forms and is independent of the work and effort put in the PR.

Adding to this, I have been thinking of busting PRs (preferably important ones) in chunks for like three weeks now, I will definitely come around to do this, once I get some time in my hands.

meetmangukiya commented 7 years ago

Ok, what do you guys mean by busting PRs :/ sounds synonymous​ to closing it :P

Makman2 commented 7 years ago

to bust a PR = taking over the PR and finish it (official entry into dictionary requested :D)

I already wanted to take up some too, though together with thesis work this has to wait.

meetmangukiya commented 7 years ago

:+1: one can easily bust 8-10 newcomer PRs a day and maybe around 3-4 low in a week ;)

meetmangukiya commented 7 years ago

Auto label PRs as bust! after 2 months of inactivity?

Makman2 commented 7 years ago

Like it :D

jayvdb commented 6 years ago

gitmate supports auto-labelling, and in coala repo it is active labelling as "status/STALE".

If we are going to close PRs, we also need to unassign the relevant issue.

I feel that this will be very helpful for beginner & extra-small PRs, which are usually busted.

But honestly I would prefer gitmate focuses on "busted" detection so we can have a queue of (newcomers) people who PR is busted and we (and bot) try to help them quickly rather than wait for a bot to discard their PR.