coala / projects

A website that showcases interesting projects, using Angular JS.
https://projects.coala.io/
GNU Affero General Public License v3.0
116 stars 223 forks source link

README.md: Remove Spacing Inconsistency #724

Closed sladyn98 closed 5 years ago

sladyn98 commented 5 years ago

Readme.md contained some spacing inconsitency which has been now removed.

Fixes https://github.com/coala/projects/issues/713

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][11:31:40] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section markdown_filenames... Executing section spacing... Executing section html... Executing section yml... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... ```
TravisBuddy Request Identifier: 961d0580-4ef1-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 03551620-4ef6-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 107fcb50-4ef7-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 08778fa0-4ef8-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f1fcae10-4efa-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e60277b0-4efb-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 063ca180-4efd-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Hey @sladyn98, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 907865e0-4efe-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 76214670-4eff-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e7e72e80-4f01-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 79e14260-4f04-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7edacc90-4f05-11e9-af0a-1da2f5ed2a53
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 66b787a0-4f07-11e9-af0a-1da2f5ed2a53
abhishalya commented 5 years ago

@sladyn98 I would've really liked if there is a single PR fixing the CI. Two PRs for same purpose makes one redundant. Although this PR references changes regarding space consistency but the goal is same. Anyways, as soon as https://github.com/coala/projects/pull/600 is finished, you need to cherry pick that commit and push here. We should be able to see the CI green here, since that commit is has been done before than this (following linear git history).

sladyn98 commented 5 years ago

@sladyn98 I would've really liked if there is a single PR fixing the CI. Two PRs for same purpose makes one redundant. Although this PR references changes regarding space consistency but the goal is same. Anyways, as soon as #600 is finished, you need to cherry pick that commit and push here. We should be able to see the CI green here, since that commit is has been done before than this (following linear git history).

Yeah @abhishalya your bang on I will remove the changes from my PR once #600 has been fixed :)

sladyn98 commented 5 years ago

@abhishalya @kriti21 https://travis-ci.org/sladyn98/projects/builds/511483343 I have linked the branch which made the CI green on my local fork you can have a look.The one problem is the asci link. I do not think I should have made that change because we just cannot remove a link from someone's project.So we need to find a workaround that.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5088ccf0-52bd-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a44a2fe0-52be-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][07:39:36] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section markdown_filenames... Executing section spacing... Executing section html... Executing section yml... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... ```
TravisBuddy Request Identifier: fc0746f0-52be-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][07:40:46] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section spacing... Executing section html... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... nothing changed, not updating cache Done. Your build exited with 1. ```
TravisBuddy Request Identifier: 260d5570-52bf-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][07:42:21] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section markdown_filenames... Executing section spacing... Executing section yml... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... ```
TravisBuddy Request Identifier: 5edb6ae0-52bf-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][07:43:14] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section markdown_filenames... Executing section spacing... Executing section html... Executing section yml... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... ```
TravisBuddy Request Identifier: 7dfe9be0-52bf-11e9-b3ee-317c5c727117
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @sladyn98, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci ``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest Executing section global... [ERROR][19:12:55] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet. Executing section commit... Executing section linecount... Executing section filenames... Executing section markdown_filenames... Executing section spacing... Executing section html... Executing section yml... Executing section new_linelength_projects... Executing section old_linelength_projects... Executing section cli... ```
TravisBuddy Request Identifier: 150c3bc0-9b6b-11e9-82c9-337585006a18
sladyn98 commented 5 years ago

@jayvdb This fixes the spacing inconsistency and is ready to be merged IMO.

jayvdb commented 5 years ago

Duplicate of #600