writing_a_great_proposol.md: update gsoc link

Shiva-sankaran commented 4 years ago

Changes the old broken link with the new link google.github.io/gsocguides/student

closes https://github.com/coala/projects/issues/642

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

[x] I read the commit guidelines and I've followed them.
[x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

LGTM! Nice work @Shiva-sankaran! tada

@abhishalya

EDIT: However, you might want to look at the commit. No need to use [text](link) in the commit. Also, make sure the body is less than 72 characters and the shortlog less than 50 characters.

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f8e07dc0-3837-11ea-b5ea-ed59922799f5

Shiva-sankaran commented 4 years ago

@frextrite @abhishalya
Even if i provide anyone of the link it exceeds the character limit. So i have removed all links from the body and changed the body correspondingly but not very informative though( if thats ok with the guidelines).

Shiva-sankaran commented 4 years ago

Hey is this PR ready to be merged or should I look into the Travis error @frextrite @abhishalya

Shiva-sankaran commented 4 years ago

@frextrite sorry about this i tried a few different commands in git in trying to force push but nothing seemed to work. The problem is i used my browser, forked repository to make this PR . now i chanced the body by again editing here in the browser. so now it seems like force push should be done in terminal and i am currecntly learning git. So the only way i found is closing this PR and starting from first again. EDIT in my cloned copy, forked copy the link are changed

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 459243e0-4cd5-11ea-8d64-99834d90edda

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e214bd10-4e33-11ea-b00e-d175f66e4ddd

Shiva-sankaran commented 4 years ago

@frextrite so i forced pushed agian after adding the closes < issue number >. so thats it or should i make anymore changes and thanks for your patience :)

Shiva-sankaran commented 4 years ago

I dont think its needed.

What do you exactly mean by that?. Should I change the link to what abishlaya suggested or not Thanks anyways this PR was inactive for 2 months

abhishalya commented 4 years ago

Sorry for the delay, I'll probably merge this on weekend.

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 45fe7160-8537-11ea-8d43-fbda637e9c03

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7a7bd4e0-8538-11ea-8d43-fbda637e9c03

Shiva-sankaran commented 4 years ago

@abhishalya I have made the changes which were suggested by you. I hope my commit follows the commit guideline ( I checked once with the api's ). Also, I hope I did force push my changes...... It's been a long time since @frextrite told me the whole procedure of force pushing.

Is Travis still broken?? I am seeing errors should I look into them?

Shiva-sankaran commented 4 years ago

Just squash these two commits into one and then force push, and this is good to go.

@abhishalya I looked on the internet regarding this and found out "git rebase -i master" command but it showed only one commit.

EDIT: I guess i figured it out i dont know why the previous command only gave the last commit. This time i used "git rebase - i HEAD~2" and removed the first commit which i made which had the google.github link for GSOC and then force pushed everything.

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 78d6db50-8b76-11ea-93df-b7a86f14bb6d

TravisBuddy commented 4 years ago

Hey @Shiva-sankaran, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 78db6f30-8b76-11ea-93df-b7a86f14bb6d

Shiva-sankaran commented 4 years ago

Okay, good enough for me. Although few things you can still take care of, like maintaining titlecase whenever required (e.g. Closes ... instead of closes).

@abhishalya I have been waiting to ask this question for a while now and i guess this is the right time to ask. Regarding the commit message, isn't it enough to share the information by writing rather than following some proper way of presenting it? Every oraganisation follows this but i don't get why? for example the thing you metioned the titlecases do they make a difference ?? NO OFFENCE.... I just wanted to know why these matter except for maintaing a uniformity and discipline in work

Also is it okay to change the titlecase( more generally edit the commit ) after it has been approved?

abhishalya commented 4 years ago

@Shiva-sankaran Yes, they do make a difference. We'd want to maintain history as pretty and explanatory as possible. But sometimes (like this) it might just be nitpicking so I approved it. This is to just let you know that you could improve small things like these so we don't have to comment about them again.

Usually, for newcomers its a good practice. Because of this single small PR you had to learn some git features, and even practically use them which you wouldn't have done otherwise. We have a separate documentation on how your commit message should look like, so you know we're serious about this. ;)

abhishalya commented 4 years ago

@Shiva-sankaran Can you please rebase this?

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6eece370-8c8c-11ea-89d0-d5fc1e9d3510

Shiva-sankaran commented 4 years ago

hey @abhishalya I think i might need some help over here i did a rebasing but my fork is still behind by 1 commit. I also made a stupid force push. I messed the whole thing up trying to rebase it I did a git fetch and then git rebase master then edited the file in text editor then git add the git rebase --continue but no effect on my fork. then i thought i need to force push but that was a bad idea

abhishalya commented 4 years ago

Do a git fetch <remote> and rebase with git rebase <remote>/master.

Replace <remote> (this repo) as specified by you.

Shiva-sankaran commented 4 years ago

Do a git fetch <remote> and rebase with git rebase <remote>/master.

Replace <remote> (this repo) as specified by you.

@abhishalya in the second line the which you specified goes to the original coala repo right?? my upstream is coala/projects repo i did these commands git fetch upstream git rebasee upstream/master

after these commands it tells about merge conflict and i resolved it manually then ran these commands git add . git rebase --continue then it said there were no changes detected to commit

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9cc14fb0-8f58-11ea-b91d-fdb092ef3eb4

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 58c24750-8f59-11ea-b91d-fdb092ef3eb4

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f3618fa0-8f59-11ea-b91d-fdb092ef3eb4

Shiva-sankaran commented 4 years ago

@abhishalya have I rebased it correctly ?? or did I rebase in the first place? Sorry I think I messed up big time again :(

abhishalya commented 4 years ago

This is the reason for failure:

**** GitCommitBear [Section: commit | Severity: NORMAL] ****

!    ! Shortlog of HEAD commit does not match given regex: ([^:]*|[^:]+[^ ]: [A-Z0-9*].*)

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b7b19020-8f7e-11ea-b91d-fdb092ef3eb4

Shiva-sankaran commented 4 years ago

This is the reason for failure:
**** GitCommitBear [Section: commit | Severity: NORMAL] ****

!    ! Shortlog of HEAD commit does not match given regex: ([^:]*|[^:]+[^ ]: [A-Z0-9*].*)
@abhishalya The regex wasn't matching with the ":" present in "https://" so I changed the commit I am not familar with regex so if I am wrong please let me know I used a online regex tool to check which parts of the commit did not match. Also, last week there were only two checks how did this many come ?? also regarding the rebase??

abhishalya commented 4 years ago

Rebase again and fix the commit shortlog, it should be fine. You don't have to worry about other checks other than the two required.

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Shiva-sankaran, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a042c240-90ed-11ea-ba10-7b1b65697aa0

Shiva-sankaran commented 4 years ago

Hey @abhishalya the checks are successful !!! Also I guess my rebase was successful cause my forked repo doesn't say n commits behind coala:master but it says that my fork is 1 commit ahead of coala:master I guess that's not a problem

abhishalya commented 4 years ago

Good work, will merge this tonight.

Shiva-sankaran commented 4 years ago

@abhishalya So,if this is done can I move on to reviewing a newcomer issue

abhishalya commented 4 years ago

Sorry it took a while, merged now :+1:

And yes, you can move up to another issue.

coala / projects