Closed chttrjeankr closed 4 years ago
TravisBuddy
commented
4 years ago Hey @chttrjeankr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
chttrjeankr
commented
4 years ago On running coala locally with HTMLLintBear on the only HTML file modified in this PR (partials/tabs/mentors.html), I get the following log.
These lines weren't modified in this PR.
@abhishalya, would like your views on the logs.
abhishalya
commented
4 years ago Oh, nvm, check the travis logs, it is complaining about git message.
chttrjeankr
commented
4 years ago Oh, nvm, check the travis logs, it is complaining about git message.
I was under the impression it exited due to the HTMLLintBear error on line 520 of the log.
chttrjeankr
commented
4 years ago Created an empty HEAD commit with a shortlog of under 50 characters. :)
chttrjeankr
commented
4 years ago Hey @abhishalya, this PR is ready to review and merge. Let me know if there's any scope for improvement.
abhishalya
commented
4 years ago @chttrjeankr Sorry for the delay, I was inactive for some time. Thanks for the PR, it looks good. :)
Just one small change I think we can do is maybe we should remove the completed tag since if we had new mentors and new gsoc then they won't show up here (since the projects weren't completed). Although, we'd like to have them list on the mentors page.
Can you make this change, I'll merge it. Also, I'm updating mentors list on https://github.com/coala/projects/pull/782 so you might've to rebase this first.
chttrjeankr
commented
4 years ago we should remove the
completedtag
I believe a better option would be to change the filter used to display mentors. Rather than just choosing completed we can also choose in progress tags and display all such mentors.
If you meant removing the tag completely from the filter, it'll display mentors from disabled projects as well.
@abhishalya I'll rebase and push my changes by EOD.
abhishalya
commented
4 years ago The thing is earlier we used to constantly participate in gsoc and we used to have new project ideas all the time. Now its slightly changed and I want the mentors to be listed as per the last gsoc we had. If its ongoing then let the list display them. I don't think we had any disabled project last year but I don't think it would've been a problem to show the mentors even if we had one.
TravisBuddy
commented
4 years ago Hey @chttrjeankr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
TravisBuddy
commented
4 years ago Hey @chttrjeankr, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
chttrjeankr
commented
4 years ago @abhishalya Rebased and made the desired changes. Open for review. :rocket:
abhishalya
commented
4 years ago Looks good, one final step. Squash these commits into one
abhishalya
commented
4 years ago Merged! Thanks for the contribution :)
Fixes: #777
For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!
Checklist
After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it out of the review queue.The more you review, the more your score will grow at coala.io and we will review your PRs faster!