projects.js: Fix randomly redirecting issue

pra17dod commented 3 years ago

This will fix the randomly redirecting issue of projects URL on refreshing the page of the project or while pasting the link in the search bar, and remove hard-coded redirection of pyFlakes as it is no more required.

Fixes https://github.com/coala/projects/issues/793

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

[x] I read the commit guidelines and I've followed them.
[x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

pra17dod commented 3 years ago

Hi @abhishalya, Please review the PR.

KVGarg commented 3 years ago

It does fix the issue, but there is another issue Say we already have a tab opened with url location https://deploy-preview-794--projects-coala.netlify.app/ and then we add ?project=real-time_team_communication_bridge&lang=en to the url

Observed Behaviour: It doesn't open the modal window of the requested project

Actual Behaviour (that should happen in general, and is observed everywhere) It should open the modal, and close any existing visible modal window

abhishalya commented 3 years ago

@KVGarg Can you create a separate issue for that, I think right now we can go ahead with this fix unless it has a very obv fix.

coala / projects

projects.js: Fix randomly redirecting issue #794

Checklist