Rewrite get-line-from-index

coalton-lang / coalton

Coalton is an efficient, statically typed functional programming language that supercharges Common Lisp.

https://coalton-lang.github.io/

MIT License

1.12k stars 67 forks source link

Rewrite get-line-from-index #1136

Closed jbouwman closed 2 months ago

jbouwman commented 2 months ago

Allow get-line-from-index to handle character offsets that point to line endings.

add assertion for requests beyond eof
rewrite in 'loop'
remove utf code point calculation: all errors are character index relative
remove column number patch
adjust test assertions

This deletes a patch that was introduced in https://github.com/coalton-lang/coalton/pull/1131

jbouwman commented 2 months ago

@stylewarning was right, there is at least one place where character vs octet indexing needs clarification -- https://github.com/coalton-lang/coalton/pull/1137 ought to be diagnosed and resolved before this is merged.