apply-ast-substitution would previously return node-lisp nodes unchanged, but if the node captures Coalton variables which must be substituted, then the application will need to generate a node-let wrapping the node-lisp.
The codegen will generate code that violates package locks if node-lisp nodes capture variable names which match existing function names and are then inlined into other packages. Accordingly, I renamed some arguments in slice.lisp and vector.lisp.
The codegen-let recursive data constructor requires node-direct-applications, but didn't explicitly check for them, which caused errors when inlining.
There are also a few other minor cleanup changes from browsing through the code.
apply-ast-substitutionwould previously returnnode-lispnodes unchanged, but if the node captures Coalton variables which must be substituted, then the application will need to generate anode-letwrapping thenode-lisp.The codegen will generate code that violates package locks if
node-lispnodes capture variable names which match existing function names and are then inlined into other packages. Accordingly, I renamed some arguments inslice.lispandvector.lisp.The
codegen-letrecursive data constructor requiresnode-direct-applications, but didn't explicitly check for them, which caused errors when inlining.There are also a few other minor cleanup changes from browsing through the code.